Fix (hopefully) the Release workflow cache#369
Merged
Conversation
The Release workflow doesn't restore the stale cache version in case of
dependency changes, causing the build to start from scratch instead of
being incremental. This might be caused by by a trailing newline in the
`restore-keys`.
In addition, this changes the cache key to remove `${{ runner.os }}`
which is irrelevant to our use as we use the `ubuntu-latest` runners
anyhow, and `-go-` since we're using a single cache anyhow so no need to
tie it to golang.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
=======================================
Coverage 78.65% 78.65%
=======================================
Files 47 47
Lines 3560 3560
=======================================
Hits 2800 2800
Misses 760 760
Flags with carried forward coverage won't be shown. Click here to find out more. |
lcarva
approved these changes
Jan 27, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Release workflow doesn't restore the stale cache version in case of dependency changes, causing the build to start from scratch instead of being incremental. This might be caused by by a trailing newline in the
restore-keys.In addition, this changes the cache key to remove
${{ runner.os }}which is irrelevant to our use as we use theubuntu-latestrunners anyhow, and-go-since we're using a single cache anyhow so no need to tie it to golang.